Skip to content

update typedoc #5555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2024
Merged

update typedoc #5555

merged 1 commit into from
Dec 2, 2024

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Dec 2, 2024 •
edited by pr-codex bot
Loading

closes: DASH-501

PR-Codex overview

This PR focuses on updating dependencies and making adjustments to the typedoc integration within the project. It includes version upgrades and some refactoring in the typedoc usage.

Detailed summary

  • Updated typedoc-better-json from 0.9.2 to 0.9.4.
  • Updated typedoc from 0.26.11 to 0.27.2.
  • Refactored import of TypeDoc to Application in typedoc.mjs.
  • Simplified entryPoints array in typedoc.mjs.
  • Updated typesVersions in package.json to a more concise format.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 01383f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel
Copy link

vercel bot commented Dec 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 9:38pm
thirdweb_playground ❌ Failed (Inspect) Dec 2, 2024 9:38pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 9:38pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 9:38pm

@jnsdls jnsdls mentioned this pull request Dec 2, 2024
Merged
@jnsdls Graphite App
Copy link
Member Author

jnsdls commented Dec 2, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls mentioned this pull request Dec 2, 2024
Merged
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Dec 2, 2024
@jnsdls jnsdls marked this pull request as ready for review December 2, 2024 18:49
@jnsdls jnsdls force-pushed the 12-02-update_dependencies branch from 15dd3e9 to e937680 Compare December 2, 2024 18:50
@jnsdls jnsdls force-pushed the 12-02-update_typedoc branch from 1bd29c0 to 5550ff5 Compare December 2, 2024 18:50
@socket-security
Copy link

socket-security bot commented Dec 2, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] Transitive: environment, filesystem, network +46 21.4 MB manantank
npm/[email protected] Transitive: environment, filesystem +18 16 MB typedoc-bot

🚮 Removed packages: npm/[email protected], npm/[email protected]

View full report↗︎

@linear
Copy link

linear bot commented Dec 2, 2024

DASH-501 update dependencies

@jnsdls jnsdls force-pushed the 12-02-update_typedoc branch 2 times, most recently from ab0da3f to 01383f8 Compare December 2, 2024 18:56
@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Dec 2, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.92 KB (0%) 959 ms (0%) 3.8 s (+45.32% 🔺) 4.7 s
thirdweb (cjs) 107.39 KB (0%) 2.2 s (0%) 5.2 s (-11.17% 🔽) 7.4 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 395 ms (+86.5% 🔺) 507 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 305 ms (+666.36% 🔺) 315 ms
thirdweb/react (minimal + tree-shaking) 18.27 KB (0%) 366 ms (0%) 494 ms (+59.74% 🔺) 859 ms

@codecov
Copy link

codecov bot commented Dec 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.98%. Comparing base (5c55314) to head (1f81390).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5555      +/-   ##
==========================================
+ Coverage   43.96%   43.98%   +0.02%     
==========================================
  Files        1083     1082       -1     
  Lines       56263    56235      -28     
  Branches     3955     3954       -1     
==========================================
- Hits        24738    24737       -1     
+ Misses      30842    30815      -27     
  Partials      683      683
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 5c55314
packages 38.78% <ø> (+0.02%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 1 file with indirect coverage changes

Base automatically changed from 12-02-update_dependencies to main December 2, 2024 21:08
@jnsdls jnsdls force-pushed the 12-02-update_typedoc branch from 01383f8 to 1f81390 Compare December 2, 2024 21:09
@jnsdls jnsdls mentioned this pull request Dec 2, 2024
Merged
@jnsdls jnsdls merged commit 00d6529 into main Dec 2, 2024
31 of 32 checks passed
@jnsdls jnsdls deleted the 12-02-update_typedoc branch December 2, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MananTank MananTank MananTank approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges joaquim-verges is a code owner

@gregfromstl gregfromstl Awaiting requested review from gregfromstl

@arcoraven arcoraven Awaiting requested review from arcoraven

Assignees

No one assigned

Labels

packages Portal Involves changes to the Portal (docs) codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jnsdls @MananTank